Fix OfflineDataset for non-array Simulator output
#364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
🚀 New features to boost your workflow:
|
Contributor
|
Thanks for the fix! Looks good I think. |
paul-buerkner
approved these changes
Mar 21, 2025
|
|
||
| def __init__(self, data: dict[str, np.ndarray], batch_size: int, adapter: Adapter | None, **kwargs): | ||
| def __init__( | ||
| self, data: dict[str, np.ndarray], batch_size: int, adapter: Adapter | None, num_samples: int = None, **kwargs |
Contributor
There was a problem hiding this comment.
We should add docs about the arguments of the DataSet classes. But I guess this can be done independently of this bug fix.
| self.adapter = adapter | ||
| self.num_samples = next(iter(data.values())).shape[0] | ||
|
|
||
| if num_samples is None: |
Contributor
There was a problem hiding this comment.
I do like that the user has both options (a) to automatically compute num_samples (default) or (b) to manually specify it, if for some reason, num_samples cannot be reliably inferred by the data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #363